@re2 review — APPROVE ✅

Checked against issue #1247 acceptance criteria:

Endpoint review:

/status:

• checkEnvConfig() validates all required secrets (4), runtime config fields (6), campaign fields (pool > 0, start < end, all milestones) — returns aggregate boolean only, no value leakage
• Three DB queries parallelized via Promise.all — efficient
• PLOTLINK_FC_FID: 0 correctly fails check (placeholder is not a valid FID)
• Streak/weekly surface removed

/leaderboard:

• Uses canonical weighted_spend RPC — no drift from T2.4b
• Sorted by weighted_spend DESC, includes multiplier + buy_volume in response
• Pagination + user rank lookup preserved

/points:

• Clean deprecation: buy-only volume within campaign window + successor-version link to /projection
• Net -94 lines — removes streak, referral, breakdown, estimated airdrop

No issues found.

Verdict: REQUEST CHANGES

Summary

The endpoint rewrites move in the intended v5 direction, but they break existing internal consumers. /points is now a thin shim while UserPoints still expects the old rich response, and /leaderboard changed its entry shape without updating the component that renders it.

Findings

• [high] /api/airdrop/points now returns only { address, buy_volume_plot, fetched_at }, but src/components/airdrop/UserPoints.tsx still fetches this endpoint and immediately reads estimatedAirdrop, totalPoints, sharePercent, breakdown, streak, and referral. The issue allowed the shim only if no internal callers remain, and the PR body says UserPoints.tsx still works, but the current code will throw as soon as it evaluates data.estimatedAirdrop[key] or renders data.totalPoints.

  • File: src/app/api/airdrop/points/route.ts:27
  • Suggestion: Either migrate UserPoints to /api/airdrop/projection plus the separate referral/streak sources it needs, or keep /points backward-compatible for the fields still consumed until the UI is migrated.

• [high] /api/airdrop/leaderboard entries no longer include totalPoints, but src/components/airdrop/Leaderboard.tsx still renders entry.totalPoints.toLocaleString(). The optional leaderboard page will crash for every non-empty response.

  • File: src/app/api/airdrop/leaderboard/route.ts:59
  • Suggestion: Update the component/types to render the new v5 fields (weighted_spend, buy_volume, multiplier) or preserve a compatible totalPoints alias during the transition.

Decision

Requesting changes until the rewritten endpoint shapes are either kept compatible with existing callers or the callers are migrated in the same PR. CI was still pending at review time.

Verdict: REQUEST CHANGES

Summary

The latest push fixes the immediate UserPoints and Leaderboard crashes by restoring the missing keys. However, /points now satisfies the TypeScript shape with hardcoded stubs for data that the current UI still uses, so the existing referral/streak workflows silently regress.

Findings

• [high] The restored /points compatibility response hardcodes streak to zero/null and referral to all null/false values instead of returning the existing data. UserPoints still drives the referral section from these fields: after a user generates a referral code via /api/airdrop/referral-code, it invalidates airdrop-points, but this endpoint will still return referral.code: null, so the share link never appears. It also always renders the “Who referred you?” input because referredBy is always null, and it hides existing referred counts.
  • File: src/app/api/airdrop/points/route.ts:58
  • Suggestion: Either restore the prior referral/streak queries while the compatibility shim is still consumed by UserPoints, or migrate UserPoints in this PR to fetch referral/status data from the replacement endpoints so existing UI behavior remains intact.

Decision

Requesting changes until the deprecated /points compatibility path preserves the behavior still required by current callers, not just the field names. CI was still pending at review time.

Verdict: APPROVE

Summary

The requested compatibility regressions are fixed. /points now preserves the fields and live referral/streak behavior still consumed by UserPoints while carrying the deprecation headers, and /leaderboard includes the totalPoints alias needed by the current component while exposing the new weighted-spend fields.

Findings

• None blocking.

Decision

Approving PR #1285. The v5 status fields, weighted-spend leaderboard path, points deprecation headers, and existing UI caller compatibility are now all covered by the implementation. Latest visible checks only showed Vercel contexts at review time, so wait for required CI contexts before merge.